Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert-related rules do not recognise assert.true() and assert.false() #169

Closed
Krinkle opened this issue Apr 5, 2021 · 1 comment · Fixed by #172
Closed

assert-related rules do not recognise assert.true() and assert.false() #169

Krinkle opened this issue Apr 5, 2021 · 1 comment · Fixed by #172

Comments

@Krinkle
Copy link
Contributor

Krinkle commented Apr 5, 2021

I was amidst addressing a warning from the qunit/no-conditional-assertions rule;

		if ( !err.stack ) {
			assert.equal(
				/(^| )qunit-source( |$)/.test( source.className ),
				false,
				"Don't add source information on unsupported environments"
			);
			return;
		}

I noticed that when I changed this to use assert.false() , the warning went away. Probably just needs to be added to ASSERTION_METADATA in

const ASSERTION_METADATA = {

@platinumazure
Copy link
Owner

Agreed, this is a bug. PR would be welcome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants