Ensure boolean assertions are not missed by several rules #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the new boolean assertions (`true` and `false`) to our list of assertions so that they will be taken into account by several rules. Adds test cases to several rules.
bmish
commented
Apr 10, 2021
| @@ -49,6 +50,7 @@ ruleTester.run("no-global-assertions", rule, { | |||
| wrap("assert.notPropEqual(a, b);"), | |||
| wrap("assert.raises(function () {}, TypeError);"), | |||
| wrap("assert.throws(function () {}, TypeError);"), | |||
| wrap("assert.true(foo);"), | |||
There was a problem hiding this comment.
I was not able to add invalid test cases to this rule for the boolean assertions. Maybe true and falsecan't be added as globals because they are reserved keywords in JS?
1 task
platinumazure
requested changes
Apr 21, 2021
Co-authored-by: Kevin Partington <platinumazure@gmail.com>
Co-authored-by: Kevin Partington <platinumazure@gmail.com>
Co-authored-by: Kevin Partington <platinumazure@gmail.com>
Co-authored-by: Kevin Partington <platinumazure@gmail.com>
Accepted your suggestions. |
platinumazure
approved these changes
Apr 21, 2021
|
Thanks! |
bmish
added a commit
to bmish/eslint-plugin-qunit
that referenced
this pull request
Apr 21, 2021
* master: Update: Ensure boolean assertions are not missed by several rules (platinumazure#172) Chore: add eslint-plugin-eslint-comments (platinumazure#178) Docs: enable/autofix indent rule in markdown JS code samples (platinumazure#177) Docs: Add eslint-plugin-markdown for JavaScript code samples in documentation (platinumazure#176) Upgrade: Bump y18n from 4.0.0 to 4.0.1 (platinumazure#163)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169. Adds the new boolean assertions (
trueandfalse) to our list of assertions so that they will be taken into account by several rules. Adds test cases to several rules.