False positive for no-hooks-from-ancestor-modules

[Krinkle]

QUnit.module( 'jquery.tablesorter.parsers', QUnit.newMwEnvironment(), function ( hooks ) {
	var originalMonths;
	hooks.beforeEach( function () {
	// ^ eslint: Do not call hooks.{{hookName}} from an ancestor module.
		originalMonths = mw.language.months;
		mw.language.months = {};
	} );
	hooks.afterEach( function () {
	// ^ eslint: Do not call hooks.{{hookName}} from an ancestor module.
		mw.language.months = originalMonths;
	} );
	
	QUnit.test( 'example', function ( assert ) {
		assert.true( true );
	} );
} );

I thought maybe it gets confused by the newMwEnvironment call that returns an options object, but it happens even if I replace it with a plain QUnit.module('example', {}, function ( hooks ) {.

[platinumazure]

Thanks @Krinkle for the issue!

Having reviewed the QUnit.module documentation, I can confidently say this is a bug. I think during initial implementation, we simply forgot that it is valid to have both a hooks object as second argument and a function callback as third argument. Instead, we check the second argument regardless.

PR would be welcome. It should be pretty easy to just add the missing test cases and then fix the code.