Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add prettier #442

Merged
merged 3 commits into from Feb 10, 2024
Merged

chore: add prettier #442

merged 3 commits into from Feb 10, 2024

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Dec 9, 2023

Fixes #84. Let me know if you like this and are still interested.

Adds prettier which is popular for automated code formatting.

I have followed the requests from this comment: #84 (comment). The only non-default option I needed to apply was tabWidth: 4.

I removed ESLint's formatting rules that conflict with prettier from eslint.config.js. But note that the prettier/recommended config also ensures any conflicting rules are disabled.

ESLint's formatting rules are deprecated so it's a good time to move away from them:

@coveralls
Copy link

coveralls commented Dec 9, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling 52d1886 on bmish:prettier
into 87890a3 on platinumazure:master.

@bmish
Copy link
Collaborator Author

bmish commented Feb 5, 2024

Ping?

* master:
  feat: support eslint flat config (platinumazure#443)
  upgrade: Bump @typescript-eslint/parser from 6.7.5 to 6.21.0 (platinumazure#465)
  upgrade: Bump typescript from 5.2.2 to 5.3.3 (platinumazure#439)
  upgrade: Bump eslint-plugin-unicorn from 49.0.0 to 51.0.1 (platinumazure#464)
  upgrade: Bump eslint-plugin-eslint-plugin from 5.1.1 to 5.3.0 (platinumazure#463)
  upgrade: Bump globals from 13.23.0 to 14.0.0 (platinumazure#462)
  upgrade: Bump eslint from 8.55.0 to 8.56.0 (platinumazure#450)
  upgrade: Bump @eslint/js from 8.55.0 to 8.56.0 (platinumazure#449)
  upgrade: Bump markdownlint-cli from 0.37.0 to 0.39.0 (platinumazure#459)
  upgrade: Bump github/codeql-action from 2 to 3 (platinumazure#447)
  upgrade: Bump eslint-doc-generator from 1.5.2 to 1.6.2 (platinumazure#455)
  upgrade: Bump release-it from 16.2.1 to 16.3.0 (platinumazure#437)
  ci: Use parallel coveralls config (platinumazure#461)
@platinumazure platinumazure merged commit 71d03e5 into platinumazure:master Feb 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestion] enable Prettier on this repository.
3 participants