Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deadline limiter #23

Merged
merged 4 commits into from
Dec 22, 2019
Merged

Add Deadline limiter #23

merged 4 commits into from
Dec 22, 2019

Conversation

platinummonkey
Copy link
Owner

  • Adds DeadlineLimiter which imposes a deadline on all token acquisitions before short-circuiting to failure.
  • Fixes Fix flaky tests #21

@coveralls
Copy link

coveralls commented Dec 22, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 151

  • 59 of 72 (81.94%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 90.326%
Changes Missing Coverage Covered Lines Changed/Added Lines %
limiter/lifo_blocking.go 0 3 0.0%
limiter/deadline.go 36 46 78.26%
Totals Coverage Status
Change from base Build 145: 1.9%
Covered Lines: 1774
Relevant Lines: 1964
💛 - Coveralls

@platinummonkey platinummonkey merged commit 86be4ef into master Dec 22, 2019
@platinummonkey platinummonkey deleted the deadline-limiter branch December 22, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix flaky tests
2 participants
@platinummonkey @coveralls