Queue impl parity #79
Conversation
limiter/lifo_blocking.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
|
|
|||
| type lifoElement struct { | |||
There was a problem hiding this comment.
These changes were included because I branched off #78
If that PR gets merged I can rebase and this diff should be resolved
limiter/queue_blocking.go
Outdated
| var element *list.Element | ||
| switch q.ordering { | ||
| case OrderingFIFO: | ||
| element = q.list.Back() | ||
| case OrderingLIFO: | ||
| element = q.list.Front() | ||
| } |
There was a problem hiding this comment.
This is essentially the biggest difference between this impl and what exists in the lifo impl. It is also the only code path where we have any logic dependent on the queue order
| @@ -0,0 +1,474 @@ | |||
| package limiter | |||
There was a problem hiding this comment.
All these tests were sourced from lifo_blocking_test.go and fifo_blocking_test.go
marcoferrer
force-pushed
the
queue-impl-parity
branch
from
bf6da34
to
1bdff02
Compare
marcoferrer
force-pushed
the
queue-impl-parity
branch
from
f45e8ae
to
21f8866
Compare
marcoferrer
force-pushed
the
queue-impl-parity
branch
3 times, most recently
from
ed5b5fe
to
92dcf34
Compare
marcoferrer
force-pushed
the
queue-impl-parity
branch
from
92dcf34
to
13bbdfe
Compare
|
looks good, mind addressing these |
No prob. Missed those. Ill take care of it now |
This PR creates a new limiter type named
QueueBlockingLimiter. This limiter is meant to replaceLifoBlockingLimiteras well asFifoBlockingLimiter. This new queue takes all the improvements made to the lifo queue implementation as well as refactors the queue implementation to use aListinternally, just like the fifo queue impl. The queue direction is controlled via configuration enum passed in at instantiation time. The existing queue tests have been ported over. If this proposal is acceptable then one thing I would like a little guidance on is what course of action to take for the existing queues and pool implementations? Would it make sense to fully deprecate the old methods and wait a few release cycles or remove them completely and release a breaking change.EDIT: I used a combination of type aliasing and embedding to deprecate the older queue limiter types