Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow language to be specified when executing a script #14

Merged
merged 2 commits into from Feb 28, 2015

Conversation

corbinbs
Copy link

Hello,

We recently released https://github.com/pokitdok/gremlin-python
and we'd like to use rexpro to easily submit python scripts to rexster for execution.
(https://github.com/pokitdok/gremlin-python#rexster)
It looks like everything is in place to do this now and we just needed to allow the language parameter to be passed in when running execute

I ran the tests locally and all of the current tests still passed:

corbinbs@~/Projects/github/rexpro-python (venv) [master] $ nosetests
............................................................
----------------------------------------------------------------------
Ran 60 tests in 6.863s

OK

please consider adding this so folks that drop gremlin-python into their rexster server can easily execute python scripts with rexpro.

Thanks for the great rexpro python library!

Brian

@platinummonkey
Copy link
Owner

This is Great! I was just reading about pokitdok/gremlin-python on the mailing list! Think you could add some example documentation on using it as a general approach? gremlin-python could be the prime example.

@corbinbs
Copy link
Author

happy to add some documentation!

where's the best spot for me to include it along with this pull request?
In the readme or somewhere in the docs folder?

@platinummonkey
Copy link
Owner

Somewhere in the docs folder, maybe create a new "examples" directory like I've done with mogwai?

@corbinbs
Copy link
Author

Sounds good - I'll give that a shot later this afternoon and post for your review

@corbinbs
Copy link
Author

I took a shot at dropping in some examples to illustrate some of the basics
There are a lot of other scenarios that could be included in the examples that are part of the gremlin-python test cases, but I've not had a chance to add all of them in here yet.

Is this close to what you were thinking for building out an examples directory?

platinummonkey pushed a commit that referenced this pull request Feb 28, 2015
allow language to be specified when executing a script
@platinummonkey platinummonkey merged commit 3a3cd77 into platinummonkey:master Feb 28, 2015
@platinummonkey
Copy link
Owner

Looks great! Thanks! I'll cut a release soon and post to PyPI

@corbinbs
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants