Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print(123.00) outputs "123.000" (extra 0 at the end) #25

Closed
JPTa opened this issue Nov 24, 2023 · 3 comments · Fixed by #26
Closed

print(123.00) outputs "123.000" (extra 0 at the end) #25

JPTa opened this issue Nov 24, 2023 · 3 comments · Fixed by #26

Comments

@JPTa
Copy link

JPTa commented Nov 24, 2023 •
edited
Loading

nokia-5110-lcd-library/src/Nokia_LCD.cpp

Line 374 in cc069fe

int num = fractional / pow(10, d);

When 'fractional' is zero it is not necessary to print it out at the end:

nokia-5110-lcd-library/src/Nokia_LCD.cpp

Line 383 in cc069fe

return (out_of_bounds || print(fractional));

platisd added a commit that referenced this issue Nov 24, 2023
@platisd
Fix print of extra 0 when floats have only zeroes as decimals
561d57a 
Fixes #25
@platisd platisd mentioned this issue Nov 24, 2023
Merged
@platisd
Copy link
Owner

platisd commented Nov 24, 2023

If I understood right, the proposed pull request (#26) will fix your issue. Do you agree?

@JPTa
Copy link
Author

JPTa commented Nov 24, 2023

Yeah, that fixes it.

platisd added a commit that referenced this issue Nov 24, 2023
@platisd
Fix print of extra 0 when floats have only zeroes as decimals (#26)
fa6af6e 
Fixes #25
@platisd
Copy link
Owner

platisd commented Nov 24, 2023

Thank you for reporting the issue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix print of extra 0 when floats have only zeroes as decimals platisd/nokia-5110-lcd-library
2 participants
@platisd @JPTa