Skip to content

Commit

Permalink
All sources component's details button to stick to the bottom when to…
Browse files Browse the repository at this point in the history
…o few items and on mobile (#1255)

* chore(docker): improve repeat contributions workflow

* This change adds two new commands to gracefully stop and remove the Postgres and Clickhouse docker containers. To do so, it also gives them a recognizable name.

* Additionally, the Postgres container is updated to use a named volume for its data. This lower friction for repeat contributions where one would otherwise sign up and activate their accounts again and again each time.

* Format countries modal

* Remove unused imports
* Run ESLint and make related fixes

* ESlint formatting for entry pages modal

* WIP: proof of concept for scrollable modals on mobile

* Revert "Merge branch 'feature/details-modal-mobile' of github.com:hirusi/analytics"

This reverts commit 87e9fb9, reversing
changes made to beea6a0.

* Fix issue with details button not sticking to the bottom

On "All Sources", the details button wouldn't stick to the bottom when there are too few sources for the date period selected. This was due to a missing class.
  • Loading branch information
MaybeThisIsRu committed Aug 23, 2021
1 parent 88c2666 commit 5ee7445
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions assets/js/dashboard/stats/sources/source-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class AllSources extends React.Component {
<span>{this.label()}</span>
</div>

<FlipMove>
<FlipMove className="flex-grow">
{this.state.referrers.map(this.renderReferrer.bind(this))}
</FlipMove>
<MoreLink site={this.props.site} list={this.state.referrers} endpoint="sources" />
Expand All @@ -97,13 +97,13 @@ class AllSources extends React.Component {

renderContent() {
return (
<LazyLoader onVisible={this.onVisible}>
<LazyLoader className="flex flex-col flex-grow" onVisible={this.onVisible}>
<div id="sources" className="flex justify-between w-full">
<h3 className="font-bold dark:text-gray-100">Top Sources</h3>
{ this.props.renderTabs() }
</div>
{ this.state.loading && <div className="mx-auto loading mt-44"><div></div></div> }
<FadeIn show={!this.state.loading}>
<FadeIn show={!this.state.loading} className="flex flex-col flex-grow">
{ this.renderList() }
</FadeIn>
</LazyLoader>
Expand Down

0 comments on commit 5ee7445

Please sign in to comment.