New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempting to create an empty Goal returns inelegant 500 error #431

Closed

1 task done

victoriadrake opened this issue Nov 21, 2020 · 2 comments

Closed

1 task done

Attempting to create an empty Goal returns inelegant 500 error #431

victoriadrake opened this issue Nov 21, 2020 · 2 comments

Labels

bug

victoriadrake commented Nov 21, 2020

Prerequisites

I have searched open and closed issues to make sure that the bug has not yet been reported.

Bug report

Visit site settings > goals. Click + Add goal.
Choose either Goal trigger.
Assume the placeholder is pre-provided text. Click Add goal →.
Receive 500 error.

Expected behavior

The form field for Page path or Event name should be required.

It would appear that validation in https://github.com/plausible/analytics/blob/master/lib/plausible/goal/schema.ex isn't working.

victoriadrake added the bug label

Contributor

ukutaht commented Nov 24, 2020

Thanks for reporting @victoriadrake !

ukutaht closed this as completed in

d879ef8

Author

victoriadrake commented Nov 27, 2020

Thank you for fixing, and for maintaining a nice product 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment