Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace webpack for esbuild #2041

Closed
wants to merge 3 commits into from

Conversation

wesleimp
Copy link
Contributor

Changes

Below you'll find a checklist. For each item on the list, check one option and delete the other.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

@@ -1,9 +1,10 @@
const colors = require('tailwindcss/colors')

module.exports = {
purge: [
content: [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ukutaht ukutaht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wesleimp ! Sorry for the delay in getting back on this

I don't see any changes to assets/package.json. We should be able to remove webpack and tailwind related packages from there as well, no?

]

config :tailwind,
version: "3.1.6",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently use tailwind version 2.1.2. Let's keep it the same instead of upgrading versions as well

@ukutaht
Copy link
Contributor

ukutaht commented Sep 5, 2023

Closing in favor of #3320

@ukutaht ukutaht closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants