Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 support for docker images #2103

Merged
merged 3 commits into from
Sep 26, 2022
Merged

ARM64 support for docker images #2103

merged 3 commits into from
Sep 26, 2022

Conversation

FarisZR
Copy link
Contributor

@FarisZR FarisZR commented Aug 13, 2022

Changes

This PR adds ARM64 builds for plausible docker images.
I tested the builds, and everything worked.

Test builds:
https://github.com/FZR-forks/analytics/pkgs/container/plausible

the latest tag is the self-hosting version
the master version is built to the latest commit

This PR requires switching from yandex/clickhouse-server to a recent clickhouse/clickhouse-server image which supports ARM64

I tested it using the latest version, which has an ARM64 image.

If this PR gets merged, I can create another one to update the hosting repo.

Related:
#1286
#903

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@DennisLoska
Copy link

@ukutaht The ARM image here is working on RPI4

@ruslandoga
Copy link
Contributor

ruslandoga commented Sep 21, 2022

@FarisZR 👋

There's been a change in how public images are built: #2152
tl;dr what had previously been in .github/workflows/docker.yml moved to .github/workflows/build-public-images.yml.

I wonder if you'd be up to rebase against master and apply the changes to the new .github/workflows/build-public-images.yml?

Either way, thank you!

@FarisZR FarisZR reopened this Sep 21, 2022
@FarisZR
Copy link
Contributor Author

FarisZR commented Sep 21, 2022

Updated, should i include the ARM build for the Private builds too?

@ruslandoga
Copy link
Contributor

Thank you!

should i include the ARM build for the Private builds too?

No, those are for Plausible.Cloud, and they are amd64 only for now :)

@ruslandoga
Copy link
Contributor

@ukutaht could you please take a look? I think it's ready.

@bundlemon
Copy link

bundlemon bot commented Sep 26, 2022

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.19KB -
static/js/dashboard.js
295.63KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ukutaht ukutaht merged commit 620e29a into plausible:master Sep 26, 2022
@XJDHDR
Copy link

XJDHDR commented Sep 28, 2022

Just wanted to make a note: This PR says: "This change does not need a documentation update". However, self-hosting.md under Requirements says:

The server must have a CPU with x86_64 architecture and support for SSE 4.2 instructions.

I think that if ARM64 CPUs are now supported, this line and possibly the rest of that section should be updated to reflect this.

@paskal
Copy link
Sponsor

paskal commented Sep 28, 2022

I was expecting the master image of plausible/analytics on DockerHub to be renewed after that PR merging, but it was not, and it seems like it's renewed manually.

I propose to push the new image with both amd64 and arm64.

@ukutaht
Copy link
Contributor

ukutaht commented Sep 29, 2022

@paskal The master and stable images are not updated on DockerHub anymore. Only tagged releases are.

@asyba
Copy link

asyba commented Dec 23, 2023

so is Raspberry ARM supported or not?

@ruslandoga
Copy link
Contributor

@asyba 👋

Starting from v1.5 plausible/analytics has arm64 support, so the later Raspberry Pi versions should be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants