Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed improvements #2148

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Embed improvements #2148

merged 6 commits into from
Sep 1, 2022

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Aug 30, 2022

Changes

Add width=manual mode to allow embed hosts to control width and alignment

Before:
Width before

New width=manual option for embed:
Width after

Merge tooltips and ensure they don't overflow

Before:
Tooltip before

Issues:

  1. Tooltip overflows the container to the left which causes issues with embeds2.
  2. Having 2 different tooltips, one for info and one for showing/hiding, is not ideal UX3.

After:
Tooltip after

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • Docs have been updated

plausible/docs#263

Dark mode

  • The UI has been tested both in dark and light mode

@bundlemon
Copy link

bundlemon bot commented Aug 30, 2022

BundleMon

Files updated (2)
Status Path Size Limits
static/js/dashboard.js
295.57KB (+7.87KB +2.74%) -
static/css/app.css
515.19KB (+95B +0.02%) -
Unchanged files (5)
Status Path Size Limits
static/js/app.js
12.13KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

Total files change +7.96KB +0.96%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

assets/js/dashboard/stats/graph/top-stats.js Outdated Show resolved Hide resolved
Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ukutaht ukutaht merged commit 7683638 into master Sep 1, 2022
@ukutaht ukutaht deleted the embed-improvements branch September 1, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants