Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sentry APP-189] Fallback to current date in all time parsing #2277

Merged
merged 2 commits into from Sep 28, 2022
Merged

[Sentry APP-189] Fallback to current date in all time parsing #2277

merged 2 commits into from Sep 28, 2022

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Sep 28, 2022

Changes

Sentry link

The All time period is failing for sites where stats_start_date=nil. This PR adds a fallback for when this field is missing.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@bundlemon
Copy link

bundlemon bot commented Sep 28, 2022 •
edited

BundleMon

Unchanged files (7)
Status Path Size Limits
✅ static/css/app.css
 515.19KB -
✅ static/js/dashboard.js
 295.63KB -
✅ static/js/app.js
 12.13KB -
✅ static/js/embed.host.js
 5.58KB -
✅ static/js/embed.content.js
 5.06KB -
✅ tracker/js/plausible.js
 748B -
✅ static/js/applyTheme.js
 314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

vinibrsl
vinibrsl approved these changes Sep 28, 2022
View reviewed changes
lib/plausible/site/schema.ex Show resolved Hide resolved
lib/plausible/site/schema.ex Show resolved Hide resolved
@vinibrsl vinibrsl merged commit 4096d88 into master Sep 28, 2022
@vinibrsl vinibrsl deleted the fix-date-parsing branch September 28, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinibrsl vinibrsl vinibrsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ukutaht @vinibrsl