Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin alpine versions to 3.18.0 #3057

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Pin alpine versions to 3.18.0 #3057

merged 2 commits into from
Jun 20, 2023

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Jun 19, 2023

This reverts commit c19a51e.

@cnkk we have two alpine image references in our Dockerfile and only one got updated. This may lead to unpredictable build oddities.

Changes

Please describe the changes made in the pull request here.

Below you'll find a checklist. For each item on the list, check one option and delete the other.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol aerosol requested a review from cnkk June 19, 2023 14:05
@bundlemon
Copy link

bundlemon bot commented Jun 19, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
307.13KB -
static/js/app.js
12.31KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.06KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@aerosol
Copy link
Member Author

aerosol commented Jun 19, 2023

actually even with the revert they're diverged already

@aerosol aerosol changed the title Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)" Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)" (pin both to 3.18) Jun 19, 2023
@aerosol aerosol changed the title Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)" (pin both to 3.18) Pin alpine versions to 3.18.0 Jun 19, 2023
Copy link
Member

@cnkk cnkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I missed this earlier

@aerosol aerosol merged commit cf4fee3 into master Jun 20, 2023
6 checks passed
@ruslandoga
Copy link
Contributor

ruslandoga commented Jun 21, 2023

Small nitpick, it doesn't seem to matter that the patch versions are different since the final image runs apk upgrade

More info: https://gist.github.com/ruslandoga/45cab5b3390f187b9cdfa0bac435a0db

For reproducible builds it might make sense to remove apk upgrade since it makes alpine:3.18.0 practically become alpine:3.18.2

@aerosol
Copy link
Member Author

aerosol commented Jun 21, 2023

Ah great, thank you for looking into it.

This PR was a knee-jerk reaction to some random errors (of unknown then source) and I only remembered we've had issues with Erlang's SSL in the past due to a imprecise bump.

@aerosol aerosol deleted the revert-alpine-upgrade branch June 21, 2023 05:35
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)"

This reverts commit c19a51e.

* Pin both images to alpine 3.18.0
ruslandoga pushed a commit that referenced this pull request Jun 27, 2023
* Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)"

This reverts commit c19a51e.

* Pin both images to alpine 3.18.0
ruslandoga pushed a commit to ruslandoga/plausible that referenced this pull request Jul 10, 2023
* Revert "Bump alpine from 3.18.0 to 3.18.2 (plausible#3044)"

This reverts commit c19a51e.

* Pin both images to alpine 3.18.0
ruslandoga pushed a commit that referenced this pull request Jul 12, 2023
* Revert "Bump alpine from 3.18.0 to 3.18.2 (#3044)"

This reverts commit c19a51e.

* Pin both images to alpine 3.18.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants