-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin alpine versions to 3.18.0 #3057
Conversation
This reverts commit c19a51e.
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
actually even with the revert they're diverged already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I missed this earlier
Small nitpick, it doesn't seem to matter that the patch versions are different since the final image runs More info: https://gist.github.com/ruslandoga/45cab5b3390f187b9cdfa0bac435a0db For reproducible builds it might make sense to remove |
Ah great, thank you for looking into it. This PR was a knee-jerk reaction to some random errors (of unknown then source) and I only remembered we've had issues with Erlang's SSL in the past due to a imprecise bump. |
* Revert "Bump alpine from 3.18.0 to 3.18.2 (plausible#3044)" This reverts commit c19a51e. * Pin both images to alpine 3.18.0
This reverts commit c19a51e.
@cnkk we have two alpine image references in our Dockerfile and only one got updated. This may lead to unpredictable build oddities.
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests
Changelog
Documentation
Dark mode