Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transport_opts to data migration #3179

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

ruslandoga
Copy link
Contributor

Changes

Closes #3173

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

@ruslandoga ruslandoga requested a review from aerosol July 24, 2023 05:20
outside of the main application supervision tree.
"""
use Ecto.Repo,
otp_app: :plausible,
adapter: Ecto.Adapters.ClickHouse

def start(url, max_threads) when is_binary(url) and is_integer(max_threads) do
default_config = Plausible.IngestRepo.config()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using IngestRepo to be consistent with

Application.get_env(:plausible, Plausible.IngestRepo)[:url]

@bundlemon
Copy link

bundlemon bot commented Jul 24, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.34KB -
static/js/dashboard.js
319KB -
static/js/app.js
40.11KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.08KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@ruslandoga ruslandoga marked this pull request as ready for review July 24, 2023 05:36
@aerosol
Copy link
Member

aerosol commented Jul 24, 2023

@ruslandoga ruslandoga mentioned this pull request Jul 24, 2023
@aerosol
Copy link
Member

aerosol commented Jul 24, 2023

Hmm this is weird: https://github.com/plausible/analytics/actions/runs/5641146895/job/15278756140?pr=3179

is it because you're submitting the PR off your fork? 🤔

@ruslandoga
Copy link
Contributor Author

ruslandoga commented Jul 24, 2023

Yeah, I think so.

I wonder why pass creds for public repos anyway? Seems to have been introduced in #3114

@aerosol aerosol mentioned this pull request Jul 24, 2023
@aerosol
Copy link
Member

aerosol commented Jul 24, 2023

maybe rate limiting. Asked @cenk

@aerosol aerosol merged commit 1c17e89 into plausible:master Jul 25, 2023
3 of 6 checks passed
@ruslandoga ruslandoga deleted the data-migration-transport-opts branch July 25, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to 2.0.0 fails to connect to Clickhouse when using IPv6
2 participants