Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply unified capitalization to buttons and titles #3321

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

aerosol
Copy link
Member

@aerosol aerosol commented Sep 5, 2023

Changes

This PR is an attempt at unified capitalization in buttons, links and titles.
Note: custom props section is not yet changed, because there's an upcoming PR redoing it completely to match the current goals UI. All relevant changes will be applied there.

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@bundlemon
Copy link

bundlemon bot commented Sep 5, 2023

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
492.35KB -
static/js/dashboard.js
318.67KB -
static/js/app.js
40.11KB -
static/js/embed.host.js
5.58KB -
static/js/embed.content.js
5.08KB -
tracker/js/plausible.js
742B -
static/js/applyTheme.js
314B -

Total files change +9B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@vinibrsl vinibrsl merged commit 29d0f82 into master Sep 5, 2023
5 checks passed
@vinibrsl vinibrsl deleted the capitalization branch September 5, 2023 12:43
aerosol added a commit that referenced this pull request Sep 5, 2023
aerosol added a commit that referenced this pull request Sep 5, 2023
There was a regression in #3321 - some keybinding
hints stopped appearing due to exact string matching.
aerosol added a commit that referenced this pull request Sep 5, 2023
* Render keybinding hints in the range picker

There was a regression in #3321 - some keybinding
hints stopped appearing due to exact string matching.

* Switch casing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants