Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "Load More" functionality to pages modal #480

Merged
merged 2 commits into from Dec 17, 2020

Conversation

Vigasaurus
Copy link
Contributor

@Vigasaurus Vigasaurus commented Dec 16, 2020

Changes

Adds "Load More" capability to pages modal - both top-pages and entry-pages. Allows for a user to get all the way to all pages, not just the top 100.

Fixed #429

For clarity: I was running into an issue with this setup where I would receive all n pages as expected, but I'd also consistently get a seemingly random n+1 page sent, which was a complete duplicate of a previously sent entry. I suspect it was just an issue with how I was generating data, as even without my changes it was appearing in my local if I bumped the limit on the pages API call (and not the live demo or my self-hosted instance). But I figured I'd mention it in case you could see any code reason for that happening.

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

@ukutaht
Copy link
Contributor

ukutaht commented Dec 17, 2020

Tested, works perfectly fine on my machine. Thank you!!

Unrelated to this PR, I noticed a regression while testing: when opening a modal popup like the pages one, the dashboard layout seems to shift to the right by a few pixels. It's annoying and it didn't used happen. The issue is on master, I'm running a git bisect to find which commit introduced the problem.

@ukutaht ukutaht merged commit d3f7c94 into plausible:master Dec 17, 2020
oliver-kriska pushed a commit to payout-one/analytics that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants