Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes couple of Flatpickr related issues #495

Merged
merged 3 commits into from Dec 21, 2020
Merged

Fixes couple of Flatpickr related issues #495

merged 3 commits into from Dec 21, 2020

Conversation

Vigasaurus
Copy link
Contributor

@Vigasaurus Vigasaurus commented Dec 21, 2020 •
edited

Changes

  • Ensures that selecting the same day for both entries in Flatpickr doesn't result in an empty graph, and instead changes to "day" view for the single day selected.
  • Does the same as Fix overly-sticky date in query parameters #470 but for from and to params, which persist when moving from a custom date range to any other period

Fixes #466

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

@ukutaht
Copy link
Contributor

ukutaht commented Dec 21, 2020

Thanks!

@ukutaht ukutaht merged commit 1174801 into plausible:master Dec 21, 2020
@ukutaht
Copy link
Contributor

ukutaht commented Dec 21, 2020

This is now deployed live

oliver-kriska pushed a commit to payout-one/analytics that referenced this pull request Dec 23, 2020
@Vigasaurus @oliver-kriska
Fixes couple of Flatpickr related issues (plausible#495)
47ef657 
* Navigates to day when same day is chosen in flatpickr

* Ensures that erroneous from and to params are removed when re-navigating

* Changelog
@Vigasaurus Vigasaurus mentioned this pull request Dec 24, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choosing same day for start and end in Flatpickr results in an empty visitors-graph
2 participants
@Vigasaurus @ukutaht