Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes case-sensitivity and residual keys in date-keybinds #709

Merged
merged 4 commits into from
Feb 18, 2021

Conversation

Vigasaurus
Copy link
Contributor

@Vigasaurus Vigasaurus commented Feb 12, 2021

Changes

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog
    With 1.2 now released, I'm unsure where you want changelog updates/the new version you're targeting

Documentation

  • This change does not need a documentation update

Copy link
Contributor

@ukutaht ukutaht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @Vigasaurus I can confirm my issue with cmd+w is fixed on your testing box.

I've updated the CHANGELOG.md on master. You can add this under 1.3 - unreleased.

I did notice some weirdness. On current master, shift+w doesn't do anything. With this PR hitting shift+w seems to clear the period query param. I would expect it to either do nothing or navigate to ?period=7d. Is this intentional or just happening on my machine?

@Vigasaurus
Copy link
Contributor Author

Hmm that seems backwards in respect to the issue, to me.

On the current master pressing shift+<any accepted key> would reset the period and date params, which was one of the bugs this was fixing.

In this PR, pressing shift+<any accepted> should do the same as the non-shift version of the key (and it behaves correctly like this for me). And in this PR, if the period is already set to the one corresponding to the key pressed, the period is left unchanged, but the date, to and from params are reset to being unset.

If you're having issues with the shift+key resetting the period, I'd have to assume that something's up with your webpack or caching; I just tried on a fresh pull and its seemingly working as described above.

@ukutaht
Copy link
Contributor

ukutaht commented Feb 18, 2021

You're correct. I must have mixed up my testing environments or something. Thanks for the contribution!

@ukutaht ukutaht merged commit e55c221 into plausible:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts: cmd does not seem to be ignored correctly
2 participants