Selfhosted version improvements

[tckb]

This PR will address some of the concerns raised during the self-hosted versions:

closes #26, closes #85, closes #86, closes #88, closes #133

• cleanup docker-compose
• separate migration step
• remove/skip plausible.io landing page for self-hosting setup
• optionally enable registration page
• optionally enable sign-in page
• add tests
• remove landing page and other unused templates
• remove Joken dependenc
• fix the app page to show login/register instead of "trial period"
• fix config param inconsistency issue and invalid value to param - closes Setting db poolsizes for postgres and clickhouse gives me a kernel dum #198

[ukutaht]

Looks good to me! Thanks for the huge work 💚 💙 💜 💛 ❤️

The only change I'd like to see is to remove the DISABLE_LANDING_PAGE variable. Some context: the / route is never hit in the cloud version of Plausible. We started out with it as the landing page but now we're running a static site in front of the app server with a reverse proxy. The static site shadows the / route to serve the landing page.

This means the / route is not even relevant to our cloud deployment. In a self-hosted scenario, its should probably:

• Redirect to /login if the user is not logged in
• Redirect to /sites if the user is logged in

Seems like that's what the DISABLE_LANDING_PAGE already does so you could just remove the env variable do it unconditionally.

[tckb]

Looks good to me! Thanks for the huge work 💚 💙 💜 💛 ❤️

The only change I'd like to see is to remove the DISABLE_LANDING_PAGE variable. Some context: the / route is never hit in the cloud version of Plausible. We started out with it as the landing page but now we're running a static site in front of the app server with a reverse proxy. The static site shadows the / route to serve the landing page.

This means the / route is not even relevant to our cloud deployment. In a self-hosted scenario, its should probably:

* Redirect to `/login` if the user is not logged in

* Redirect to `/sites` if the user is logged in

Seems like that's what the DISABLE_LANDING_PAGE already does so you could just remove the env variable do it unconditionally.

I thought about that, but since it being a opensource, I do not want to rule out a possibility that someone with a fork want to customize the landing page and would still want have a landing page. we can set this variable to true by default.

I would probably would want to customize it somehow -- What do you think ?

[ukutaht]

I still don't see much reason to keep it tbh. If someone has a fork and they're adding code for a landing page, it shouldn't be a big ask to also change the Pagecontroller.Index handler to render the landing page instead of doing redirection.

Instead of referencing an old landing page we don't use anymore, it would be better to reference the code for our live landing page.

The main reason I want to remove it is because our CSS is compiled based on the classes used in the actual HTML templates. By removing the landing page we remove some of Tailwind's CSS classes from being included in the final build. This would make the whole app lighter.

[tckb]

The main reason I want to remove it is because our CSS is compiled based on the classes used in the actual HTML templates. By removing the landing page we remove some of Tailwind's CSS classes from being included in the final build. This would make the whole app lighter.

Okay, I agree on the size part. So removing the templates at https://github.com/plausible/analytics/tree/master/lib/plausible_web/templates/page would suffice right?

[ukutaht]

Okay, I agree on the size part. So removing the templates at https://github.com/plausible/analytics/tree/master/lib/plausible_web/templates/page would suffice right?

Yeah, and changing the controller to redirect based on the login state here:
https://github.com/plausible/analytics/blob/master/lib/plausible_web/controllers/page_controller.ex#L25

[tckb]

Yeah, and changing the controller to redirect based on the login state here:

This is already handled by auto_auth_plug.

I will remove unnecessary assets and templates to needed for self-hosting

[ukutaht]

Cool 👍 I will merge once those are removed

[ukutaht]

One more thing, let's make the landing page disabled by default.

[tckb]

One more thing, let's make the landing page disabled by default.

If I remove the template, then there wouldn't be any landing page :P I am not sure if I understand this correctly