Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plausible/analytics container port local only #24

Closed
wants to merge 1 commit into from

Conversation

mabasic
Copy link
Contributor

@mabasic mabasic commented Dec 3, 2020

This change makes the container plausible/analytics accessible only from localhost (127.0.0.1).

I think that this should be the default because:

  • to use plausible with a https website, plausible should be served from https. Requires reverse proxy.
  • using plausible with http makes it vulnerable to "hackers" when entering admin password and the entire traffic can be seen by "anyone", thus making it insecure.

The docs should reflect these points even if this PR is not accepted.

This change makes the container plausible/analytics accessible only from localhost (127.0.0.1). 

I think that this should be the default because:
- to use plausible with a https website, plausible should be served from https. Requires reverse proxy.
- using plausible with http makes it vulnerable to "hackers" when entering admin password and the entire traffic can be seen by "anyone", thus making it insecure.
@Vigasaurus
Copy link

Vigasaurus commented Dec 14, 2020

Not to mention opening docker ports like originally set up bypasses various firewall tools - including ufw - creating a whole host of other potential security holes.(I was mistaken about this part, don't mind me) I do think this change will also need a bit of a documentation update because the instructions for loading the login screen over http rely on the port being open globally without a reverse proxy.

@mabasic
Copy link
Contributor Author

mabasic commented Dec 14, 2020

With port forwarding you could access the web ui before setting up a reverse proxy.

@ukutaht
Copy link
Contributor

ukutaht commented Dec 14, 2020

Yeah I'm happy to merge but documentation will need to be updated. I am planning to cut a release this month so I'll do it then.

@ACPK
Copy link

ACPK commented Aug 10, 2021

@ukutaht Should this be closed?

@mabasic
Copy link
Contributor Author

mabasic commented Sep 8, 2022

@ukutaht will this be merged or closed? Almost two years have passed :)

@ukutaht
Copy link
Contributor

ukutaht commented Sep 8, 2022

I think having it accessible from the world is a good first experience with hosting it since you don't need to finish the proxy setup to play around with the product itself.

Some might run it in a private or firewalled network with the reverse proxy on a separate machine.

How about adding a very strong suggestion in the docs to not leave the container exposed to the world? That way we do our part in helping people secure their installations but also have a nice first-run experience.

@mabasic
Copy link
Contributor Author

mabasic commented Sep 13, 2022

@ukutaht I've created a PR for docs here.

@mabasic mabasic closed this Sep 13, 2022
aerosol added a commit to plausible/docs that referenced this pull request Sep 14, 2022
…se proxy (#271)

* Update self-hosting.md

Relates to plausible/community-edition#24

* Update docs/self-hosting.md

Co-authored-by: Adam Rutkowski <hq@mtod.org>

Co-authored-by: Adam Rutkowski <hq@mtod.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants