refactor dumpers and loaders #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ruslandoga
force-pushed
the
simplify-ch-type
branch
from
5b54ef9
to
d022d5d
Compare
4 tasks
ruslandoga
force-pushed
the
simplify-ch-type
branch
2 times, most recently
from
20b882b
to
01b1d71
Compare
daviaws
reviewed
Jul 24, 2023
lib/ecto/adapters/clickhouse.ex
Outdated
| defp bool_decode(1), do: {:ok, true} | ||
| defp bool_decode(0), do: {:ok, false} | ||
| @doc false | ||
| def bool_decode(1), do: {:ok, true} |
There was a problem hiding this comment.
when is number, anything diff from 0 is true, right?
There was a problem hiding this comment.
I think it depends on what type you are using in ClickHouse:
- for
Boolthere are only 1 and 0 - for
UInt80..255 can be returned, but then 2..255 is more like undefined behaviour
ruslandoga
force-pushed
the
simplify-ch-type
branch
2 times, most recently
from
2f2f5f6
to
58cd30a
Compare
ruslandoga
force-pushed
the
simplify-ch-type
branch
from
58cd30a
to
1bc1fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.