Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect localStorage.plausible_ignore #17

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Respect localStorage.plausible_ignore #17

merged 1 commit into from
Oct 14, 2021

Conversation

Windvis
Copy link
Contributor

@Windvis Windvis commented Oct 14, 2021

Description

This change ensures no events are sent if localStorage.plausible_ignore is set to "true". This behaviour is consistent with the standalone script.

Related Issue

#8

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Windvis
Copy link
Contributor Author

Windvis commented Oct 14, 2021

Should I add documentation for this? I assumed it wasn't needed since it's already documented in the docs. Maybe a link to the docs is enough?

I added a brief section to the readme which links to the Plausible documentation.

This change ensures no events are sent if `localStorage.plausible_ignore` is set to `"true"`. This behaviour is consistent with the standalone script.
@ukutaht
Copy link
Contributor

ukutaht commented Oct 14, 2021

Thanks!

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #17 (e9867d2) into master (daea747) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #17   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           73        76    +3     
  Branches        18        19    +1     
=========================================
+ Hits            73        76    +3     
Impacted Files Coverage Δ
src/lib/request.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daea747...e9867d2. Read the comment docs.

@ukutaht ukutaht merged commit cca8ef7 into plausible:master Oct 14, 2021
@Windvis Windvis deleted the feature/respect-plausible_ignore branch October 14, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants