Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basil serve error in Mac #27

Closed
chrisjaque1990 opened this issue Mar 12, 2013 · 8 comments
Closed

basil serve error in Mac #27

chrisjaque1990 opened this issue Mar 12, 2013 · 8 comments
Assignees
Labels

Comments

@chrisjaque1990
Copy link

Christians-Mac:whack-that-mole Christian$ basil serve

               {{ Game Closure SDK }}                   
                   release-0.1.7
                Life is squill.Pane

[basil] [error] [TypeError: Arguments to path.join must be strings]

@thiagolp90
Copy link

Same problem... but, i use Linux...

@mikehenrty
Copy link
Contributor

This is something we are seeing with node v0.10. We are investigating currently.

@ghost ghost assigned bubbleboy14 Mar 13, 2013
@mikehenrty
Copy link
Contributor

This is fixed upstream and will go out with the next release. In the meantime if you want to patch it yourself, go to /src/ProjectManager.js line 41 and change

var localProjects = fs.readdirSync(localProjectsPath).map(common.paths.projects);

to this:

var localProjects = fs.readdirSync(localProjectsPath).map(function (filename) {
    return common.paths.projects(filename);
});

@chrisjaque1990
Copy link
Author

not found this code in line 44 but found this in line 41:

var localProjects = fs.readdirSync(localProjectsPath).map(common.paths.projects);

and i change for this:

var localProjects = fs.readdirSync(localProjectsPath).map(function (filename) {
return common.paths.projects(filename);
});

is correct???

@mikehenrty
Copy link
Contributor

@chrisjaque1990 That looks like a separate bug. Please report it in a new issue.

@chrisjaque1990
Copy link
Author

oks sorry will update comment in this issue, but the change is correct?

@mikehenrty
Copy link
Contributor

Yup, your change is correct. I've updated my earlier comment to reflect it. Thanks!

@mikehenrty
Copy link
Contributor

Fixed in the latest release.

bubbleboy14 pushed a commit that referenced this issue Sep 13, 2013
* removed restriction forcing appID to 32 chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants