Client side compile for simulator - faster simulator #238
Conversation
| @@ -54,6 +50,8 @@ exports.serveWeb = function (opts, cb) { | |||
| app.use('/compile/', importMiddleware(getPath('static/'))); | |||
|
|
|||
| // serve static files | |||
| var devkitPath = path.resolve(__dirname, '..', '..'); | |||
| app.use('/devkit/', express.static(devkitPath)); | |||
There was a problem hiding this comment.
this feels a little excessive, do we need to serve the entire devkit directory?
There was a problem hiding this comment.
Serving the entire thing because its part of the available path ingame, I
think. If we don't need devkit on the games path, we don't have to serve
the whole thing (or if there are specific subpaths)
On Jul 29, 2015 1:23 PM, "Martin Hunt" notifications@github.com wrote:
In src/serve/index.js
#238 (comment):@@ -54,6 +50,8 @@ exports.serveWeb = function (opts, cb) {
app.use('/compile/', importMiddleware(getPath('static/')));// serve static files
- var devkitPath = path.resolve(__dirname, '..', '..');
- app.use('/devkit/', express.static(devkitPath));
this feels a little excessive, do we need to serve the entire devkit
directory?—
Reply to this email directly or view it on GitHub
https://github.com/gameclosure/devkit/pull/238/files#r35807066.
There was a problem hiding this comment.
Is it really? I thought only module code was available, and then only the folders specified in a module's package config.
- copied from devkit-core - build hooks now return all responses and which module they came from - build hooks now accept hooks returning promises rather than calling a callback - fix bug returning build result from buildQueue
Matching PRs on gameclosure/devit-core and gameclosure/js.io.
This turns off server side compilation for simulator builds, allowing the client to make better use of the browser cache. The goal of this PR was to bring simulator rebuild times to ~1 second.