New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add replace! (a means to update ALL of the fields in a vertex) #31

Open

shirlenator wants to merge 2 commits into master from upsert-vertex

shirlenator commented Jan 23, 2013

No description provided.

shirlenator added 2 commits

January 23, 2013 10:19


          add replace! (a means to update ALL of the fields in a vertex)

a3b528d


          change name from replace to update-all

f776694

Contributor

ZackGC commented Jan 23, 2013

Why use this instead of hermes.vertex/upsert!? (This is a really good function to include, but I'd like to see the rationale written out.)
The name doesn't feel right. Perhaps update-by-kv instead.
Please write tests for this.
The code seems a bit complicated. This should work the same:

(defn update-by-kv!
  "Given a key, a value, and a property map, update-all! finds all nodes with 
  the given key value pair and updates all fields with the new properties 
  by the map (not excluding the given k-v). Returns the set of vertices just replaced, if any."
  [k v m]
  (ensure-graph-is-transaction-safe)
  (doall (set (map #(set-properties! % m) (find-by-kv (name k) v))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment