New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show album name, link to album, remove button #33
Conversation
mtodd
commented
Nov 13, 2011
👎. Not a fan (I originally had this). I think it gums up the interface a bit (although admittedly the "show album" button does that a bit too). Ideally @jsncostello comes in and shows us all up at some point. |
dude i'm in the middle of a parking lot in hawaii |
Hahah, damnit @holman, that's not a good enough excuse! ❤️ |
Just messing around. 2nd row is the hover state over the album cover, which would be the album download link. No idea if access to album art is easy or not. It would be cool if it were. Made stars more like stars in other UIs (Twitter, Campfire) instead of a button. Making one button primary would help make things feel less cluttered since the other buttons could be more subtle and less distracting. Use any, all, none — again, just messing around with it. I realize the social stuff is missing - I am not a fan of it (mostly just don't find it useful) but it could be an easy thing to show with a toggle or some sort of progressive disclosure thing. |
YES! ✨ I don't know about the album art either, though there may be an API to hit that can make that feasible. The social stuff actually helps know who queued something up and how many votes it has. I find it useful for blaming certain sons of bitches for playing Garth Brookes. :) The album art would be a link to the album itself, which has the download link. 👍 making only one button the primary button, though I don't know if the download button would be the one I'd pick, but the unqueue button surely wouldn't be it either. What would this look like with the Play button included? |
love it. I want to build this, but Matt, if you're more available in the next week and want something to hack on, do it to it. Feel free to merge some of your other pulls in and I'll pull 'em all. |
pretty sure we don't have access to album art either. We could probably download it at time of indexing though. Alternatively, just hit an API on each page load. I've wanted album art for Hubot integration too, fwiw |
Could use this https://github.com/johnallen3d/amazon-album-art and cache the album art returned. |
@mtodd Make play the primary button ⚡ |
AudioInfo has something you can call against the path to tell you if there are any pictures in the folder for this song: |
Superseded on the |