flush every chunk only for chunked responses #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanns
referenced
this pull request
in yanns/play2-war-plugin
May 14, 2014
The handling of a play result in the default request handler is moved to pushPlayResultToServletOS. This handling stayed the same. This change should not have any impact on the existing servlet wrapper for servlet < 3.1. For servlet 3.1, pushPlayResultToServletOS is overwritten to provide a non-blocking asynchron handling based on the new WriteListener.
|
Good work ! |
| @@ -223,7 +229,7 @@ class Play2Servlet31RequestHandler(servletRequest: HttpServletRequest) | |||
|
|
|||
| setHeaders(headers, httpResponse) | |||
|
|
|||
| val chunked = headers.exists { case (key, value) => key == HeaderNames.TRANSFER_ENCODING && value == HttpProtocol.CHUNKED } | |||
| chunked = headers.exists { case (key, value) => key == HeaderNames.TRANSFER_ENCODING && value == HttpProtocol.CHUNKED } | |||
There was a problem hiding this comment.
key.equalsIgnoreCase(...) would be technically correct here. Though we don't do it in Play... we probably should. I think this is going to be fixed by a PR in the works that converts the headers map to be case insensitive.
There was a problem hiding this comment.
thanks, added a commit for this.
reference: http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 ("Field names are case-insensitive")
|
@dlecan can you merge this pull or do you need more info/time? |
dlecan
added a commit
that referenced
this pull request
Jun 2, 2014
flush every chunk only for chunked responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let the servlet container buffer the response.
Based on feedback from @jroper:
yanns@b580b8c#commitcomment-6312809
yanns@b580b8c#commitcomment-6312832