Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt project is loading without errors + migration from Build.scala to build.sbt #322

Merged
merged 5 commits into from Aug 17, 2018

Conversation

pwyczes
Copy link
Contributor

@pwyczes pwyczes commented Jun 29, 2018

When I forked the repo, sbt project was not loading on branch develop.
I figured it out, that there was an old sbt version in use, and "com.typesafe" % "config" was missing from both plugins and source code, so I added it.
I might start working on #321 after this fix.

@pwyczes pwyczes changed the title sbt project is loading without errors sbt project is loading without errors + migration from Build.scala to build.sbt Jun 29, 2018
@pwyczes
Copy link
Contributor Author

pwyczes commented Jul 17, 2018

Hi there, is there anything else I can do in order to push this pull request forward? :)

@yanns
Copy link
Member

yanns commented Jul 30, 2018

Hi @pwyczes
Thx for the PR.
I'm back from vacations and will take some time to look at your PR(s) after I'm back into daily business.
Please have some patience, thx!

@pwyczes
Copy link
Contributor Author

pwyczes commented Aug 17, 2018

Hi @yanns
I am just wondering if you had a chance to look at those PR(s)? :)
I am not rushing though. ;)

Copy link
Member

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR.

Could you please update the sbt version to the last one 0.13.17. The 0.13.16 fixes loading sbt on certain terminals.

Otherwise good work 👍

@pwyczes
Copy link
Contributor Author

pwyczes commented Aug 17, 2018

Thank you. :)
I've changed it to 0.13.17 in the github editor, which created new commits - is it ok?

Copy link
Member

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@yanns yanns merged commit 230f035 into play2war:develop Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants