Skip to content

Commit

Permalink
[Fix] Don’t delete the framebuffer owned by the context (#5728)
Browse files Browse the repository at this point in the history
Co-authored-by: Martin Valigursky <mvaligursky@snapchat.com>
  • Loading branch information
mvaligursky and Martin Valigursky committed Oct 6, 2023
1 parent 2822ed9 commit 3fc8bf0
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/platform/graphics/webgl/webgl-render-target.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ class WebglRenderTarget {
this._isInitialized = false;

if (this._glFrameBuffer) {
gl.deleteFramebuffer(this._glFrameBuffer);
if (this._glFrameBuffer !== this.suppliedColorFramebuffer)
gl.deleteFramebuffer(this._glFrameBuffer);
this._glFrameBuffer = null;
}

Expand All @@ -80,7 +81,8 @@ class WebglRenderTarget {
}

if (this._glResolveFrameBuffer) {
gl.deleteFramebuffer(this._glResolveFrameBuffer);
if (this._glResolveFrameBuffer !== this.suppliedColorFramebuffer)
gl.deleteFramebuffer(this._glResolveFrameBuffer);
this._glResolveFrameBuffer = null;
}

Expand All @@ -98,6 +100,7 @@ class WebglRenderTarget {
gl.deleteRenderbuffer(this._glMsaaDepthBuffer);
this._glMsaaDepthBuffer = null;
}
this.suppliedColorFramebuffer = undefined;
}

get initialized() {
Expand Down

0 comments on commit 3fc8bf0

Please sign in to comment.