Forward Renderer error when using first layer

[LeXXik]

Steps to reproduce:

1. Add an opaque layer to the very top of the layers list (before World) and give it a name, e.g. "Custom"
2. Use script that adds a camera with this layer:

    var layer = this.app.scene.layers.getLayerByName('Custom');
    var cameraEntity = new pc.Entity();
    cameraEntity.addComponent('camera', {
        clearColor: new pc.Color(0.0, 0.0, 0.0, 0.0),
        layers: [layer.id],
    });    
    this.app.root.addChild(cameraEntity);

Forward Renderer throws an error:


cameraPass is 0 in this case, resulting in settings being undefined.

[mvaligursky]

This is on my radar to fix already, but I don't have a fix yet.
It's related to a layer which uses shadow map from directional light used before the shadow map is rendered for that frame.

[devcem]

I came here to raise a bug ticket for that issue. Adding Custom layer on directional light solves issue, ALSO on engine code checking "settings" variable on that line and if it's not exist setting the "pass" variable to 0 solves issue.

Here is the line :

engine/src/scene/forward-renderer.js

Line 1369 in 0342db0

settings = light._visibleCameraSettings[cameraPass];

Here is the screenshot for change :

@mvaligursky