-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Anim file into separate files for each class it contains #2589
Comments
Hey @mvaligursky, I would like to take a crack at this as my first contribution to a open source project, if no one has started on it? |
@ellthompson works on this code base .. so let's see what he says - he might have some changes in flight in that code. Welcome and thanks @Dlewis89 ! |
No problem @mvaligursky. If you have anything else that you have for a junior dev. Let me know and I'll take a swing at it. |
What would you think about this? |
Sure I'll take a look and let you know if I have any questions. Thanks @mvaligursky. |
Hi @Dlewis89, noone I know of is actively working on the |
Hey @ellthompson, sorry but I have to put this on hold for the meanwhile. I actually just got a job with php and laravel, so I have to buckle down and make sure learn the code base and hope my php is as good as I think since I was focusing on javascript but a job is a job lol. I really appreciate the opportunity and i'll come back to help out once I am settled in at the new job. |
@Dlewis89 That's fine, i'll pick this task up myself. All the best with the new job! |
This would make it easier to navigate and understand the code.
https://github.com/playcanvas/engine/blob/master/src/anim/anim.js
current content:
export { AnimBinder, AnimClip, AnimCurve, AnimData, AnimEvaluator, AnimSnapshot, AnimTarget, AnimTrack, DefaultAnimBinder };
The text was updated successfully, but these errors were encountered: