Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Anim file into separate files for each class it contains #2589

Closed
mvaligursky opened this issue Dec 3, 2020 · 8 comments · Fixed by #2663
Closed

Separate Anim file into separate files for each class it contains #2589

mvaligursky opened this issue Dec 3, 2020 · 8 comments · Fixed by #2663
Assignees
Labels
good first issue Good for newcomers

Comments

@mvaligursky
Copy link
Contributor

mvaligursky commented Dec 3, 2020

This would make it easier to navigate and understand the code.

https://github.com/playcanvas/engine/blob/master/src/anim/anim.js

current content:

export { AnimBinder, AnimClip, AnimCurve, AnimData, AnimEvaluator, AnimSnapshot, AnimTarget, AnimTrack, DefaultAnimBinder };

@Dlewis89
Copy link

Hey @mvaligursky, I would like to take a crack at this as my first contribution to a open source project, if no one has started on it?

@mvaligursky
Copy link
Contributor Author

@ellthompson works on this code base .. so let's see what he says - he might have some changes in flight in that code.

Welcome and thanks @Dlewis89 !

@Dlewis89
Copy link

No problem @mvaligursky. If you have anything else that you have for a junior dev. Let me know and I'll take a swing at it.

@mvaligursky
Copy link
Contributor Author

mvaligursky commented Dec 10, 2020

What would you think about this?
#2569
There's already good example for this linked there.

@Dlewis89
Copy link

Sure I'll take a look and let you know if I have any questions. Thanks @mvaligursky.

@ellthompson
Copy link
Contributor

Hi @Dlewis89, noone I know of is actively working on the src/anim/anim.js file. If you'd like to take this on, that'd be great!

@Dlewis89
Copy link

Hey @ellthompson, sorry but I have to put this on hold for the meanwhile. I actually just got a job with php and laravel, so I have to buckle down and make sure learn the code base and hope my php is as good as I think since I was focusing on javascript but a job is a job lol. I really appreciate the opportunity and i'll come back to help out once I am settled in at the new job.

@ellthompson
Copy link
Contributor

@Dlewis89 That's fine, i'll pick this task up myself. All the best with the new job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants