Build directory not cleared before build "all" targets

[epreston]

Build directory is not cleared before rebuilding all targets.

Normally, the expectation is that:

• building one or specific set of targets - do not clear
• building all targets - rimraf the build dir before building

Options:

• Can be done via cli before "npm run build" with a rimraf command.
• Can be done in code in the build script

Example for rollup.config.mjs in the default export

  // if building a specific format, do not remove build.
  if (!targets.length && existsSync(`build`)) {
    await fs.rm(`build`, { recursive: true });
  }

I ran into an issue that confused me when I thought some files were not being built. They are no longer part of the build but were left there from 3 weeks ago. Clearing the directory on full builds will ensure this does not happen again.

It will also ensure extra files are not published to npm bloating the bundle size. For example "common.js" in the shaders directory, removed in a commit a few weeks ago, in a recent publish.

[willeastcott]

The build command should probably build the TypeScript declarations too then.

[mvaligursky]

keen to do all this @epreston ? I'd love to have this.

[epreston]

On the way.

[epreston]

Ready for review. A little re-org for clarity and the normal clean-up logic on "build all".

[kungfooman]

The build command should probably build the TypeScript declarations too then.

Fully agree, but we still lack build/playcanvas.d.ts after npm run build now

[mvaligursky]

Yes, I got hit by this yesterday and it took me a while to figure out what is missing. It'd be great to add.

[epreston]

On the way.

[epreston]

@willeastcott , @mvaligursky , @kungfooman

A command already exists to build types after the library is built.

npm run build:publish

It is defined as:

"build:publish": "npm run build && npm run build:types",

You can be confident that it is clean because the first command purges the directory.

Correction: it does not purge the types directory. There's a misconfiguration / expectation that needs discussion.

[mvaligursky]

Hi interesting .. personally I'd remove the publish target and make the build do this.
@slimbuck @willeastcott - any thoughts?

[epreston]

Can I speed up the build 10x first by swapping a few rollup plugins ? Then we add to it ?

The best in class plugin for this at the moment does both at the same time. Worth taking a look at.

[mvaligursky]

Sure, create a separate issue / pr and go for it, keen to see what it is.