feat(build): clean build folder before rebuilding all targets #5695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify build file by separating custom rollup plugins into reusable units
clear build directory before rebuilding all targets.
mvaligursky
requested review from
marklundin,
willeastcott,
slimbuck and
mvaligursky
mvaligursky
approved these changes
Oct 4, 2023
|
Anytime, send through anything you need done. I want to explore reusing those plugins. I have a build change in mind, this will make it easier to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans the "Build" directory before rebuilding all targets.
Normally, the expectation is that:
Resolves the edge cases described in linked issue.
This improves the readability of the build logic by separating custom rollup plugins into reusable units. Moving them into the "utils" folder and out of the root of the project.
Fixes: #5588
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.