Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception or Not Exception #93

Closed
Maksims opened this issue Nov 27, 2014 · 2 comments
Closed

Exception or Not Exception #93

Maksims opened this issue Nov 27, 2014 · 2 comments
Labels

Comments

@Maksims
Copy link
Contributor

Maksims commented Nov 27, 2014

Currently if something slightly goes a bit off planned, it throws exceptions, for example:

  • Texture is not size power of 2.
  • mp3 is not supported.
  • material pointed by model mapping is not available.
  • shader failed to compile.
  • script exception.
    And many others.

The reaction currently it is throwing internal exceptions and very unclear messages to console, that people perceive as engine bug, then it fails to load or work at all.

Desirable behaviour:
Console dev friendly messages with identifiers of error source and explanation of what to look at. Then apply default material, texture, etc just to keep game working even with black textures / blank materials etc.

Scripting
When scripting fails, it starts spawning crazy messages on every update, should it in development mode follow this behaviour: Console dev friendly message with identifiers of error source and pointer to script file + line number, then disable script, and keep going.
That will allow artists to still work with project even if coder is breaking stuff around.

Specific Cases

  1. Sending not valid value type to shader uniforms, throws exceptions. Should prevent uploading to WebGL value unless it is valid, and console.warn uniform name and material name that tries to set invalid value to.
  2. Material unavailable asset is referenced but asset is not available from resources. Should not throw exception, but console.warn ID of unavailable asset, entity name and index of sub-model, that material was referenced in.
@willeastcott
Copy link
Contributor

Can you submit specific bugs? Otherwise, it will be impossible to close this.

@Maksims
Copy link
Contributor Author

Maksims commented Nov 27, 2014

In general this is more "practice" rather than specific issue.
Yes there is big list of problems. We can tackle them one by one, I will post specific examples later on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants