Fix 2D element touchend event firing #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes annoying issue with 2D elements events. Reproduce: 1. Tap on element and keep holding it 2. Tap somewhere else 3. Release element. `Touchend` event doesn't fire then. It appears because in _handleTouchStart we overwrite _touchedElements, which contains also a previously tapped event. So instead of replacing, we merge it and then it works in appropriate way. There is also a more clear solution with Object.assign, but I'm not sure about that, since it's on ES6. Test project: https://playcanvas.com/project/557165/overview/touch-issue
Fix 2D touchend issue
yayhi
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes annoying issue with 2D elements events.
Reproduce:
Touchendevent doesn't fire then.It appears because in _handleTouchStart we overwrite _touchedElements, which contains also a previously tapped event.
So instead of replacing, we merge it and then it works in appropriate way.
There is also a more clear solution with Object.assign, but I'm not sure about that, since it's on ES6.
Test project: https://playcanvas.com/project/557165/overview/touch-issue
I confirm I have signed the Contributor License Agreement.