New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fix properties and other improvements #1675
Merged
willeastcott
merged 31 commits into
playcanvas:master
from
aidinabedi:feature/jsdoc-fix-properties
Sep 1, 2019
Merged
[DOC] Fix properties and other improvements #1675
willeastcott
merged 31 commits into
playcanvas:master
from
aidinabedi:feature/jsdoc-fix-properties
Sep 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates
tsd-jsdoc
to 2.40, which adds support for@property
(among other things). I should know I added all the new features in thistsd-jsdoc
update 😉Property fixes:
@property
types (referencing constants) in multiple classespc.ParticleSystemComponent#blend
@property
tag inpc.SoundInstance3d
pc.Asset#resources
)pc.StandardMaterial#shader
,#stencilFront
,#stencilBack
pc.ModelComponent#asset
pc.Entity
pc.MeshInstance#node
and#mesh
pc.VertexIterator#element
pc.CurveSet#type
pc.Curve#type
pc.Scene#defaultMaterial
pc.GraphicsDevice#fullscreen
pc.GraphicsDevice#maxPixelRatio
pc.GraphicsDevice#textureFloatHighPrecision
pc.GraphicsDevice#textureHalfRenderable and #textureHalfFloatRenderable
pc.Mat3#data
andpc.Mat4#data
pc.Mesh#primitive
Other improvements:
pc.GraphicsDevice#draw
pc.ResourceHandler#patch
as optionalpc.SHADER_FORWARD
pc.Application
constructor parameterpc.Keyboard
constructor parameterI confirm I have signed the Contributor License Agreement.