Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the API has
pc.Frustum#update
which takes two matrices (view and projection). It would be cleaner to have a function which sets the frustum planes from a single generic matrix. Therefore, this PR deprecatespc.Frustum#update
and replaces it with the better namedpc.Frustum#setFromMat4
(which is consistent withpc.Quat#setFromMat4
too). This eliminates a matrix mult op every frame in the forward renderer too.I confirm I have signed the Contributor License Agreement.