Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed animation.currentTime for GLB animations #2309

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fixed animation.currentTime for GLB animations #2309

merged 1 commit into from
Jul 22, 2020

Conversation

yaustar
Copy link
Contributor

@yaustar yaustar commented Jul 21, 2020

Fixes #2308

I confirm I have signed the Contributor License Agreement.

@yaustar yaustar added bug area: animation Animation related issue labels Jul 21, 2020
@yaustar yaustar requested review from ellthompson and a team July 21, 2020 16:09
@yaustar yaustar self-assigned this Jul 21, 2020
slimbuck
slimbuck approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM, but also make sure with @ellt92

@yaustar yaustar merged commit 46a142d into master Jul 22, 2020
@yaustar yaustar deleted the anim-current-time-fix branch July 22, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellthompson ellthompson ellthompson approved these changes

@slimbuck slimbuck slimbuck approved these changes

Assignees

@yaustar yaustar

Labels
area: animation Animation related issue bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

animation.currentTime throws exception if AnimEvaluator is used instead of a skeleton
3 participants
@yaustar @ellthompson @slimbuck