Expose glTF bufferView to callbacks #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the way bufferViews are handled in GlbParser and adds support for
preprocess,processAsyncandpostprocesscallbacks. This callback support will allow us to easily integrate bufferView-based compression schemes, for example https://github.com/zeux/meshoptimizer.ContainerHandler's asynchronous callbacks were changed. The
processAsynchandlers are now always called, but if the handler invokes the continuation without an error or result (i.e.callback(null, null);), this indicates the resource was unhandled and GlbParser continues to load the resource as usual.Also fixed a bug with MiniStats sometimes failing to update it's dynamic texture.
I confirm I have signed the Contributor License Agreement.