Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform-feedback particle simulation engine example #2326

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Transform-feedback particle simulation engine example #2326

merged 2 commits into from
Jul 29, 2020

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jul 29, 2020 •
edited

  • new engine example
  • transform feedback integration with SpectorJS
  • error when transform feedback is used with non-interleaved buffer (has to be interleaved)

Screen Shot 2020-07-29 at 4 54 02 PM

@mvaligursky mvaligursky self-assigned this Jul 29, 2020
slimbuck
slimbuck approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this runs on Safari?

src/graphics/transform-feedback.js Outdated Show resolved Hide resolved
@mvaligursky
Copy link
Contributor Author

Did you test this runs on Safari?

Transform-feedback needs webgl2, so no Safari .. but it's handled by example and nothing renders (no crash).

@mvaligursky mvaligursky merged commit f41f307 into master Jul 29, 2020
@mvaligursky mvaligursky deleted the mvaligursky-tranffeedback-example branch July 29, 2020 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@raytranuk raytranuk Awaiting requested review from raytranuk

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvaligursky @slimbuck