Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share vertex buffer for meshes inside a glb to avoid duplication #2491

Merged
merged 1 commit into from Oct 23, 2020
Merged

Share vertex buffer for meshes inside a glb to avoid duplication #2491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 37 additions & 12 deletions src/resources/parser/glb-parser.js
View file
Open in desktop
Expand Up @@ -437,11 +437,29 @@ var createVertexBufferInternal = function (device, sourceDesc, disableFlipV) {
return vertexBuffer;
};

var createVertexBuffer = function (device, attributes, indices, accessors, bufferViews, disableFlipV) {
// build vertex buffer format desc and source
var sourceDesc = {};
for (var attrib in attributes) {
var createVertexBuffer = function (device, attributes, indices, accessors, bufferViews, disableFlipV, vertexBufferDict) {

// extract list of attributes to use
var attrib, useAttributes = {}, attribIds = [];
for (attrib in attributes) {
if (attributes.hasOwnProperty(attrib) && gltfToEngineSemanticMap.hasOwnProperty(attrib)) {
useAttributes[attrib] = attributes[attrib];

// build unique id for each attribute in format: Semantic:accessorIndex
attribIds.push(attrib + ":" + attributes[attrib]);
}
}

// sort unique ids and create unique vertex buffer ID
attribIds.sort();
var vbKey = attribIds.join();

// return already created vertex buffer if identical
var vb = vertexBufferDict[vbKey];
if (!vb) {
// build vertex buffer format desc and source
var sourceDesc = {};
for (attrib in useAttributes) {
var accessor = accessors[attributes[attrib]];
var accessorData = getAccessorData(accessor, bufferViews);
var bufferView = bufferViews[accessor.bufferView];
Expand All @@ -459,14 +477,18 @@ var createVertexBuffer = function (device, attributes, indices, accessors, buffe
normalize: accessor.normalized
};
}
}

// generate normals if they're missing (this should probably be a user option)
if (!sourceDesc.hasOwnProperty(SEMANTIC_NORMAL)) {
generateNormals(sourceDesc, indices);
// generate normals if they're missing (this should probably be a user option)
if (!sourceDesc.hasOwnProperty(SEMANTIC_NORMAL)) {
generateNormals(sourceDesc, indices);
}

// create and store it in the dictionary
vb = createVertexBufferInternal(device, sourceDesc, disableFlipV);
vertexBufferDict[vbKey] = vb;
}

return createVertexBufferInternal(device, sourceDesc, disableFlipV);
return vb;
};

var createVertexBufferDraco = function (device, outputGeometry, extDraco, decoder, decoderModule, indices, disableFlipV) {
Expand Down Expand Up @@ -598,7 +620,7 @@ var createSkin = function (device, gltfSkin, accessors, bufferViews, nodes) {
var tempMat = new Mat4();
var tempVec = new Vec3();

var createMesh = function (device, gltfMesh, accessors, bufferViews, callback, disableFlipV) {
var createMesh = function (device, gltfMesh, accessors, bufferViews, callback, disableFlipV, vertexBufferDict) {
var meshes = [];

gltfMesh.primitives.forEach(function (primitive) {
Expand Down Expand Up @@ -689,7 +711,7 @@ var createMesh = function (device, gltfMesh, accessors, bufferViews, callback, d
// if mesh was not constructed from draco data, use uncompressed
if (!vertexBuffer) {
indices = primitive.hasOwnProperty('indices') ? getAccessorData(accessors[primitive.indices], bufferViews) : null;
vertexBuffer = createVertexBuffer(device, primitive.attributes, indices, accessors, bufferViews, disableFlipV);
vertexBuffer = createVertexBuffer(device, primitive.attributes, indices, accessors, bufferViews, disableFlipV, vertexBufferDict);
primitiveType = getPrimitiveType(primitive);
}

Expand Down Expand Up @@ -1347,8 +1369,11 @@ var createMeshes = function (device, gltf, bufferViews, callback, disableFlipV)
return [];
}

// dictionary of vertex buffers to avoid duplicates
var vertexBufferDict = {};

return gltf.meshes.map(function (gltfMesh) {
return createMesh(device, gltfMesh, gltf.accessors, bufferViews, callback, disableFlipV);
return createMesh(device, gltfMesh, gltf.accessors, bufferViews, callback, disableFlipV, vertexBufferDict);
});
};

Expand Down