Don't crash when using destroyed textures #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2513
This PR fixes a crash that happens when a texture which has already been destroyed is still referenced by a material in the scene.
When the scene is next rendered, the texture will have its WebGL interfaces created etc and will ultimately crash at https://github.com/playcanvas/engine/blob/master/src/graphics/device.js#L1799 because
_levelsisnull.This PR sets
texture._levelsto the constructor default value instead ofnullthereby circumventing the crash.I confirm I have signed the Contributor License Agreement.