Null a potentially dangling screen entity reference on remove #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where a user may remove an element entity when the screen entity is being destroyed by nulling a potentially dangling reference to the screen entity.
Repo: https://playcanvas.com/editor/scene/1023656 (press 1)
The existing code assumed (as an optimisation) that if the screen entity is being destroyed, then there is no need to call _updateScreen as it is going to get destroyed too.
I do feel like the edge case will have problems as it relies on the order of operations of entities being destroyed that are internal to the engine and that child elements should be removed before the parent is destroyed.
I confirm I have signed the Contributor License Agreement.