Further prefilter fixes #2528
Merged
Further prefilter fixes #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Nov 4, 2020
willeastcott
reviewed
Nov 4, 2020
| @@ -167,6 +167,12 @@ mat3 matrixFromVector(vec3 n) { // frisvad | |||
| return mat3(b1, b2, n); | |||
| } | |||
There was a problem hiding this comment.
Is this now unused? Any reason not to delete it and make matrixFromVectorSlow into matrixFromVector?
There was a problem hiding this comment.
I would like to keep it around for more accurate performance testing, but ultimately if we don't expose both as user options it can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #2522 :
Use a slower but better quality basis creation and normalise vector correctly.