Prefilter shader fix #2531
Merged
Prefilter shader fix #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
approved these changes
Nov 6, 2020
mvaligursky
reviewed
Nov 6, 2020
Comment on lines
+31
to
+33
| return vec3(avec.x != M ? 1.0 : 0.0, | ||
| avec.y != M ? 1.0 : 0.0, | ||
| avec.z != M ? 1.0 : 0.0); |
There was a problem hiding this comment.
this might perform slightly better
return vec3(notEqual(avec, vec3(M, M, M)));
There was a problem hiding this comment.
cool! will try it out thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clear coat material was rendering incorrectly on iOS with the recently updated prefilter shader (see #2522).
This PR reimplements the shader to work on iOS (while unfortunately re-introducing 6 texture samples), but keeps the seams fix.
It will be worth re-investigating whether the original fix can work on iOS.
I confirm I have signed the Contributor License Agreement.