Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc.createMesh reimplemented using Mesh API #2966

Merged
merged 2 commits into from Mar 15, 2021
Merged

pc.createMesh reimplemented using Mesh API #2966

merged 2 commits into from Mar 15, 2021

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Mar 15, 2021 •
edited

  • allows for 32bit index buffer
  • sets up blend weights and blend indices correctly to 4 components instead of 2

Fixes #2951

@mvaligursky mvaligursky self-assigned this Mar 15, 2021
@mvaligursky mvaligursky added the area: graphics Graphics related issue label Mar 15, 2021
slimbuck
slimbuck approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a beautiful thing

@mvaligursky mvaligursky merged commit bb72a80 into master Mar 15, 2021
@mvaligursky mvaligursky deleted the mvaligursky-createmesh-refactor branch March 15, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott Awaiting requested review from willeastcott

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc.createMesh doesn't use device.extUintElement?
2 participants
@mvaligursky @slimbuck