-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of set.equals #3097
Conversation
I can't find this function in the JavaScript standard library: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set If |
it's a polyfill from the future when JS implements this function ;) do we have some better place to add these? Perhaps we could create a new folder for these. Or just add it to "/core"? |
My feeling is that if we are not polyfilling a legitimately existing JS language feature/function, we shouldn't screw with standard library classes, poking in our own stuff. You could stick a utility function in |
Feels like it could be better named, consistent with Vec3 for example: |
extracted from #2990