Move app destroy to frame end #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2021 21:19
This reverts commit d725667.
|
It seems like a valid request to be able to shut down the application from within the update, and so I think the solution is fine. |
mvaligursky
reviewed
Jun 11, 2021
src/framework/application.js
Outdated
| @@ -408,6 +408,8 @@ class Application extends EventHandler { | |||
|
|
|||
| app = this; | |||
|
|
|||
| this._destroyThisFrame = false; | |||
There was a problem hiding this comment.
I would perhaps rename this to _destroyRequested
mvaligursky
reviewed
Jun 11, 2021
src/framework/application.js
Outdated
| @@ -2162,6 +2170,7 @@ var makeTick = function (_app) { | |||
| application._fillFrameStats(); | |||
| // #endif | |||
|
|
|||
| this._inFrameUpdate = true; | |||
There was a problem hiding this comment.
have this variable in the constructor as well please, to not introduce variables to class during running.
|
Made changes from review and here's the test project: https://playcanvas.com/editor/scene/1067584 |
mvaligursky
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3228
I'm really unsure about this as it is a kludge. I was thinking it might be better off as extra documentation for the function where app.destroy should not be called in an app.update.
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.